Browse Source

Fix issue with bottomPassed and topPassed

pull/5929/head
Jack 7 years ago
parent
commit
3bbaf137b5
2 changed files with 8 additions and 3 deletions
  1. 7
      RELEASE-NOTES.md
  2. 4
      src/definitions/behaviors/visibility.js

7
RELEASE-NOTES.md

@ -1,10 +1,15 @@
## RELEASE NOTES ## RELEASE NOTES
### Version 2.2.14 - Oct 18, 2017
**Bugs**
- **Visibility** - Fixes issue where `bottomPassed` and `topPassed` would not fire under some conditions
### Version 2.2.13 - Aug 07, 2017 ### Version 2.2.13 - Aug 07, 2017
**Hotfix** (2) **Hotfix** (2)
- **Install** - Some interactive install script issues may be fixed. Forked `gulp-prompt` plugin to allow for updated `inquirer` version - **Install** - Some interactive install script issues may be fixed. Forked `gulp-prompt` plugin to allow for updated `inquirer` version
- **Build Tools** - Fixes typo causing fix for build tools to fail [#5391](https://github.com/Semantic-Org/Semantic-UI/issues/5391)
- **Build Tools** - Fixes typo causing fix for build tools to fail [#5391](https://github.com/Semantic-Org/Semantic-UI/issues/5391)
### Version 2.2.12 - Aug 07, 2017 ### Version 2.2.12 - Aug 07, 2017

4
src/definitions/behaviors/visibility.js

@ -927,8 +927,8 @@ $.fn.visibility = function(parameters) {
// visibility // visibility
element.topPassed = (screen.top >= element.top); element.topPassed = (screen.top >= element.top);
element.bottomPassed = (screen.top >= element.bottom); element.bottomPassed = (screen.top >= element.bottom);
element.topVisible = (screen.bottom >= element.top) && !element.bottomPassed;
element.bottomVisible = (screen.bottom >= element.bottom) && !element.topPassed;
element.topVisible = (screen.bottom >= element.top) && !element.topPassed;
element.bottomVisible = (screen.bottom >= element.bottom) && !element.bottomPassed;
element.pixelsPassed = 0; element.pixelsPassed = 0;
element.percentagePassed = 0; element.percentagePassed = 0;

Loading…
Cancel
Save