Browse Source

Fix eventNamespace in #3396

pull/5282/merge
Jack 7 years ago
parent
commit
3827fd0a82
2 changed files with 5 additions and 6 deletions
  1. 2
      RELEASE-NOTES.md
  2. 9
      src/definitions/modules/modal.js

2
RELEASE-NOTES.md

@ -33,7 +33,7 @@
- **Popup** - Popup can now position elements correctly even when they have a different offset context than their activating element. Like in [this example](https://jsfiddle.net/g853mc03/). - **Popup** - Popup can now position elements correctly even when they have a different offset context than their activating element. Like in [this example](https://jsfiddle.net/g853mc03/).
To preserve functionality `movePopup` has remained as `true` (moving the popup to the same offset context), however now setting `movePopup: false` should in all cases position correctly, helping prevent sticky inheritance issues caused by moving the DOM tree around.
To preserve functionality `movePopup` default has remained as `true` (moving the popup to the same offset context), however now setting `movePopup: false` should now always position correctly. Be sure to use `movePopup: true` to avoid issues with `ui popup` inside `menu`, `input` or other places where it may inherit rules from its activating element or its context.
- **Modal** - Modal has been rewritten to use `flexbox`. No need to call `refresh()` to recalculate vertical centering. - **Modal** - Modal has been rewritten to use `flexbox`. No need to call `refresh()` to recalculate vertical centering.
- **Modal** - Modals now have a setting `centered` which can be used to disable vertical centering. This can be useful for modals with content that changes dynamically to prevent content from jumping in position. - **Modal** - Modals now have a setting `centered` which can be used to disable vertical centering. This can be useful for modals with content that changes dynamically to prevent content from jumping in position.

9
src/definitions/modules/modal.js

@ -109,7 +109,7 @@ $.fn.modal = function(parameters) {
defaultSettings = { defaultSettings = {
debug : settings.debug, debug : settings.debug,
variation : settings.centered variation : settings.centered
? ''
? false
: 'top aligned' : 'top aligned'
, ,
dimmerName : 'modals' dimmerName : 'modals'
@ -515,7 +515,7 @@ $.fn.modal = function(parameters) {
}, },
clickaway: function() { clickaway: function() {
$dimmer $dimmer
.off('click' + elementNamespace)
.off('click' + elementEventNamespace)
; ;
}, },
bodyStyle: function() { bodyStyle: function() {
@ -615,7 +615,7 @@ $.fn.modal = function(parameters) {
}, },
clickaway: function() { clickaway: function() {
$dimmer $dimmer
.on('click' + elementNamespace, module.event.click)
.on('click' + elementEventNamespace, module.event.click)
; ;
}, },
dimmerSettings: function() { dimmerSettings: function() {
@ -627,10 +627,9 @@ $.fn.modal = function(parameters) {
defaultSettings = { defaultSettings = {
debug : settings.debug, debug : settings.debug,
dimmerName : 'modals', dimmerName : 'modals',
variation : false,
closable : 'auto', closable : 'auto',
variation : settings.centered variation : settings.centered
? ''
? false
: 'top aligned' : 'top aligned'
, ,
duration : { duration : {

Loading…
Cancel
Save