Browse Source

Add ability to get popup and change content with behavior

pull/3130/merge
Jack 9 years ago
parent
commit
36fc2ac7ca
3 changed files with 16 additions and 0 deletions
  1. 6
      RELEASE-NOTES.md
  2. 9
      src/definitions/modules/popup.js
  3. 1
      src/themes/default/elements/icon.overrides

6
RELEASE-NOTES.md

@ -8,6 +8,7 @@
- **Dropdown** - Added `onLabelRemove` callback that allows value removal to be cancelled by callback **Thanks @goloveychuk**
- **Table** - Added `selectable` on table cell, allowing for full table-cell links
- **Popup** Added three new variables for `arrow` background color based on position, top, center or bottom. This makes it easier to use gradient backgrounds with popups and still match arrow colors.
- **Popup** - Added behaviors `get popup` and `change content` to more easily determine popup from activating element and change text
**Major Bug Fixes**
- **Checkbox/Dropdown/Search** - Fixed issue where using `.trigger('change')` would not fire native `change` event. Only triggering event handlers attached with jQuery #3108
@ -25,11 +26,16 @@
- **Grid** - Fixes attached segment 1px offset inside grid column #3226
- **Grid** - Fixes some inconsistencies with `widescreen only` class #3161 **Thanks @mdehoog**
- **Popup** - Fixes positioning issue when `movePopup: false` #3213 **Thanks @parisholley**
- **Progress* - Calling `reset` will now reset `value` to 0, so increment starts again at 0
- **Search** - Fixes `onSearchQuery` not firing when results are cached **Thanks @mnquintana**
- **Search** - Fixes `url` parameter not working correctly due to typo in source **Thanks @fabienb4**
- **Segment** - Fixes border on `horizontal segment` when they are `:first-child` inside `segments` group
- **Sticky** - Fixes bug where sticky would stick at incorrect times when using a different scroll container than `body` and when the container's `scrollTop` is not 0 on init.
**Docs Bugs**
- Thanks to everyone who has submitted PRs for typos, grammatical changes. These are too numerous to count, but really help improve the quality of our docs.
- **Progress** - Progress example code no longer shows accidental inline css
### Version 2.1.4 - Sep 13, 2015
**Critical Bugfixes**

9
src/definitions/modules/popup.js

@ -423,6 +423,12 @@ $.fn.popup = function(parameters) {
}
},
change: {
content: function(html) {
$popup.html(html);
}
},
get: {
html: function() {
$module.removeData(metadata.html);
@ -440,6 +446,9 @@ $.fn.popup = function(parameters) {
$module.removeData(metadata.variation);
return $module.data(metadata.variation) || settings.variation;
},
popup: function() {
return $popup;
},
popupOffset: function() {
return $popup.offset();
},

1
src/themes/default/elements/icon.overrides

@ -682,6 +682,7 @@ i.icon.triangle.right:before { content: "\f0da"; }
i.icon.envelope:before { content: "\f0e0"; }
i.icon.conversation:before { content: "\f0e6"; }
i.icon.umbrella:before { content: "\f0e9"; }
i.icon.clipboard:before { content: "\f0ea"; }
i.icon.lightbulb:before { content: "\f0eb"; }
i.icon.ambulance:before { content: "\f0f9"; }
i.icon.medkit:before { content: "\f0fa"; }

Loading…
Cancel
Save