Browse Source

Adds #3744 - Calling dropdown() on select initialized as dropdown now works

pull/4273/merge
Jack 7 years ago
parent
commit
313f8f4a4a
2 changed files with 20 additions and 7 deletions
  1. 13
      RELEASE-NOTES.md
  2. 14
      src/definitions/modules/dropdown.js

13
RELEASE-NOTES.md

@ -5,9 +5,22 @@
**Critical Bugs** (1)
- **Build Tools** - Fixes issue with deprecated uglify setting that could cause build tools to fail
```bash
GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError: `preserveComments` is not a supported option
```
**Bugs** (1)
- **Dropdown** - Fixed an issue where css rule for `focused default text` was not being applied for multiselects #5633
**Enhancements**
- **Dropdown** - Calling dropdown methods on a `<select>` turned into a dropdown will now automatically pass settings to the initialized dropdown, #3744
```javascript
$('select').dropdown();
// somewhere later
$('select').dropdown('onChange', function(value) { console.log(value) });
```
### Version 2.2.11 - July 11, 2017
**Critical Bugs** (5)

14
src/definitions/modules/dropdown.js

@ -94,7 +94,9 @@ $.fn.dropdown = function(parameters) {
module.debug('Initializing dropdown', settings);
if( module.is.alreadySetup() ) {
console.log('fixing', $module.get(0));
module.setup.reference();
console.log('new reference', $module.get(0));
}
else {
module.setup.layout();
@ -383,19 +385,16 @@ $.fn.dropdown = function(parameters) {
reference: function() {
module.debug('Dropdown behavior was called on select, replacing with closest dropdown');
// replace module reference
$module = $module.parent(selector.dropdown);
$module = $module.parent(selector.dropdown);
instance = $module.data(moduleNamespace);
element = $module.get(0);
module.refresh();
module.setup.returnedObject();
// invoke method in context of current instance
if(methodInvoked) {
instance = module;
module.invoke(query);
}
},
returnedObject: function() {
var
$firstModules = $allModules.slice(0, elementIndex),
$lastModules = $allModules.slice(elementIndex + 1)
$lastModules = $allModules.slice(elementIndex + 1)
;
// adjust all modules to use correct reference
$allModules = $firstModules.add($module).add($lastModules);
@ -3517,6 +3516,7 @@ $.fn.dropdown = function(parameters) {
;
passedArguments = passedArguments || queryArguments;
context = element || context;
console.log(query, instance, context);
if(typeof query == 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;

Loading…
Cancel
Save