#2766, concatenated stream removes dupes

RELEASE-NOTES.md

@@ -30,6 +30,7 @@
 
 **[Reported Bugs](https://github.com/Semantic-Org/Semantic-UI/issues?q=is%3Aissue+milestone%3A2.1.0+is%3Aclosed)**
 - **Accordion** - Added missing notation for accordion docs #2812
+- **Build Tools** - Fixes issue where component glob `{tab, table}` caused table to be included twice in concatenated source **
 - **Container** - Fix issue with `fluid container` being `100% + gutter` at mobile resolution (causing overflow)
 - **Dropdown** - Remove use of `trim` which causes issues IE 11 and below #2806
 - **Dropdown** - Fixes issues with setting "" (empty quote) values when `placeholder: false` is used. Fixes issues with using `clear` and `restore defaults` without placeholders. #2637

package.json

@@ -27,6 +27,7 @@
     "gulp-concat": "*",
     "gulp-concat-css": "*",
     "gulp-copy": "*",
+    "gulp-dedupe": "*",
     "gulp-flatten": "*",
     "gulp-header": "*",
     "gulp-help": "*",
@@ -57,6 +58,7 @@
     "gulp-concat": "^2.6.0",
     "gulp-concat-css": "^2.2.0",
     "gulp-copy": "0.0.2",
+    "gulp-dedupe": "0.0.2",
     "gulp-flatten": "^0.1.0",
     "gulp-header": "^1.2.2",
     "gulp-help": "^1.6.0",

tasks/collections/internal.js

@@ -16,6 +16,7 @@ module.exports = function(gulp) {
     concat     = require('gulp-concat'),
     concatCSS  = require('gulp-concat-css'),
     clone      = require('gulp-clone'),
+    dedupe     = require('gulp-dedupe'),
     gulpif     = require('gulp-if'),
     header     = require('gulp-header'),
     less       = require('gulp-less'),
@@ -52,6 +53,7 @@ module.exports = function(gulp) {
   gulp.task('package uncompressed css', function() {
     return gulp.src(output.uncompressed + '/**/' + globs.components + globs.ignored + '.css')
       .pipe(plumber())
+      .pipe(dedupe())
       .pipe(replace(assets.uncompressed, assets.packaged))
       .pipe(concatCSS(filenames.concatenatedCSS))
         .pipe(gulpif(config.hasPermission, chmod(config.permission)))
@@ -64,6 +66,7 @@ module.exports = function(gulp) {
   gulp.task('package compressed css', function() {
     return gulp.src(output.uncompressed + '/**/' + globs.components + globs.ignored + '.css')
       .pipe(plumber())
+      .pipe(dedupe())
       .pipe(replace(assets.uncompressed, assets.packaged))
       .pipe(concatCSS(filenames.concatenatedMinifiedCSS))
         .pipe(gulpif(config.hasPermission, chmod(config.permission)))
@@ -77,6 +80,7 @@ module.exports = function(gulp) {
   gulp.task('package uncompressed js', function() {
     return gulp.src(output.uncompressed + '/**/' + globs.components + globs.ignored + '.js')
       .pipe(plumber())
+      .pipe(dedupe())
       .pipe(replace(assets.uncompressed, assets.packaged))
       .pipe(concat(filenames.concatenatedJS))
         .pipe(header(banner, settings.header))
@@ -89,6 +93,7 @@ module.exports = function(gulp) {
   gulp.task('package compressed js', function() {
     return gulp.src(output.uncompressed + '/**/' + globs.components + globs.ignored + '.js')
       .pipe(plumber())
+      .pipe(dedupe())
       .pipe(replace(assets.uncompressed, assets.packaged))
       .pipe(concat(filenames.concatenatedMinifiedJS))
         .pipe(uglify(settings.concatUglify))
@@ -107,6 +112,7 @@ module.exports = function(gulp) {
 
     gulp.task('package uncompressed rtl css', function () {
       return gulp.src(output.uncompressed + '/**/' + globs.components + globs.ignoredRTL + '.rtl.css')
+        .pipe(dedupe())
         .pipe(replace(assets.uncompressed, assets.packaged))
         .pipe(concatCSS(filenames.concatenatedRTLCSS))
           .pipe(gulpif(config.hasPermission, chmod(config.permission)))
@@ -118,6 +124,7 @@ module.exports = function(gulp) {
 
     gulp.task('package compressed rtl css', function () {
       return gulp.src(output.uncompressed + '/**/' + globs.components + globs.ignoredRTL + '.rtl.css')
+        .pipe(dedupe())
         .pipe(replace(assets.uncompressed, assets.packaged))
         .pipe(concatCSS(filenames.concatenatedMinifiedRTLCSS))
           .pipe(gulpif(config.hasPermission, chmod(config.permission)))
@@ -130,6 +137,7 @@ module.exports = function(gulp) {
 
     gulp.task('package uncompressed docs css', function() {
       return gulp.src(output.uncompressed + '/**/' + globs.components + globs.ignored + '.css')
+        .pipe(dedupe())
         .pipe(plumber())
         .pipe(replace(assets.uncompressed, assets.packaged))
         .pipe(concatCSS(filenames.concatenatedCSS))
@@ -141,6 +149,7 @@ module.exports = function(gulp) {
 
     gulp.task('package compressed docs css', function() {
       return gulp.src(output.uncompressed + '/**/' + globs.components + globs.ignored + '.css')
+        .pipe(dedupe())
         .pipe(plumber())
         .pipe(replace(assets.uncompressed, assets.packaged))
         .pipe(concatCSS(filenames.concatenatedMinifiedCSS))
@@ -164,6 +173,7 @@ module.exports = function(gulp) {
 
   gulp.task('package uncompressed docs css', function() {
     return gulp.src(docsOutput.uncompressed + '/**/' + globs.components + globs.ignored + '.css')
+      .pipe(dedupe())
       .pipe(plumber())
       .pipe(replace(assets.uncompressed, assets.packaged))
       .pipe(concatCSS(filenames.concatenatedCSS))
@@ -175,6 +185,7 @@ module.exports = function(gulp) {
 
   gulp.task('package compressed docs css', function() {
     return gulp.src(docsOutput.uncompressed + '/**/' + globs.components + globs.ignored + '.css')
+      .pipe(dedupe())
       .pipe(plumber())
       .pipe(replace(assets.uncompressed, assets.packaged))
       .pipe(concatCSS(filenames.concatenatedMinifiedCSS))
@@ -188,6 +199,7 @@ module.exports = function(gulp) {
 
   gulp.task('package uncompressed docs js', function() {
     return gulp.src(docsOutput.uncompressed + '/**/' + globs.components + globs.ignored + '.js')
+      .pipe(dedupe())
       .pipe(plumber())
       .pipe(replace(assets.uncompressed, assets.packaged))
       .pipe(concat(filenames.concatenatedJS))
@@ -200,6 +212,7 @@ module.exports = function(gulp) {
 
   gulp.task('package compressed docs js', function() {
     return gulp.src(docsOutput.uncompressed + '/**/' + globs.components + globs.ignored + '.js')
+      .pipe(dedupe())
       .pipe(plumber())
       .pipe(replace(assets.uncompressed, assets.packaged))
       .pipe(concat(filenames.concatenatedMinifiedJS))