From 26fe5ba81c6b3fd155adf870f71e7a3f841ffac6 Mon Sep 17 00:00:00 2001 From: jlukic Date: Tue, 14 Apr 2015 12:12:11 -0400 Subject: [PATCH] #2070 - dont continue loop unnecessarily, clarify variable names --- src/definitions/modules/search.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/definitions/modules/search.js b/src/definitions/modules/search.js index b0547ce2f..8690525c6 100644 --- a/src/definitions/modules/search.js +++ b/src/definitions/modules/search.js @@ -134,11 +134,12 @@ $.fn.search = function(parameters) { href = $link.attr('href') || false, target = $link.attr('target') || false, title = $title.html(), - name = ($title.length > 0) + // title is used for result lookup + value = ($title.length > 0) ? $title.text() : false, results = module.get.results(), - result = module.get.result(name, results), + result = module.get.result(value, results), returnedValue ; if( $.isFunction(settings.onSelect) ) { @@ -148,8 +149,8 @@ $.fn.search = function(parameters) { } } module.hideResults(); - if(name) { - module.set.value(name); + if(value) { + module.set.value(value); } if(href) { module.verbose('Opening search link found in result', $link); @@ -304,7 +305,7 @@ $.fn.search = function(parameters) { if($.isArray(category.results)) { result = module.search.object(value, category.results, true)[0]; if(result && result.length > 0) { - return true; + return false; } } });