From 1ab71653ee5a606d6ae1d804b5b5eaecbd263de2 Mon Sep 17 00:00:00 2001 From: jlukic Date: Wed, 25 Mar 2015 16:59:25 -0400 Subject: [PATCH] Fix issue with popup removal --- RELEASE-NOTES.md | 1 + src/definitions/modules/popup.js | 3 +++ 2 files changed, 4 insertions(+) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 6f4a02652..09c51ea98 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -71,6 +71,7 @@ - **Modal** - `scrollable modal` now correctly adds padding below modal - **Modal** - Modal with `detachable: false` inside `ui sidebar` `pusher` element will now show correctly - **Popup** - Fixes issue with `min-width` in firefox exceeding `max-width` causing element to not wrap correctly +- **Popup** - Fixed bug which could cause pre-existing inline popup to be removed from DOM after hiding - **Search** - Search API calls now use the same level debug settings as search - **Tab** - Tab name is no longer case sensitive - **Table** - `very basic table` now works together with `padded table` diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js index aa818798e..8dad27319 100644 --- a/src/definitions/modules/popup.js +++ b/src/definitions/modules/popup.js @@ -96,6 +96,7 @@ $.fn.popup = function(parameters) { else { if(settings.inline) { $popup = $target.next(selector.popup).eq(0); + settings.popup = $popup; } } if(settings.popup) { @@ -337,6 +338,8 @@ $.fn.popup = function(parameters) { removePopup: function() { module.debug('Removing popup', $popup); if( module.has.popup() && !settings.popup) { + console.log('removing'); + debugger; $popup.remove(); $popup = undefined; }