Browse Source

Fixes useFailSafe to work with queued animations #1848

pull/1875/head
jlukic 10 years ago
parent
commit
14281784a7
2 changed files with 16 additions and 5 deletions
  1. 12
      RELEASE-NOTES.md
  2. 9
      src/definitions/modules/transition.js

12
RELEASE-NOTES.md

@ -1,14 +1,17 @@
## RELEASE NOTES
### Version 1.9.4 - February 21, 2015
### Version 1.10.0 - February 23, 2015
**Updates**
**Critical Fixes**
- **Transition** - Webkit `failSafe` used for [Chromium Bug #437860](https://code.google.com/p/chromium/issues/detail?id=437860) now also works for queued animations
**Enhancements**
- **Form Validation** - Adds `containsExactly`, `notExactly`, `isExactly` case sensitive validation rules, make `contains`, `not`, `is` case insensitive.
- **Form Validation** - `contains` rule is now case insensitive
- **Form Validation** - Validation messages no longer increase field height on `inline fields` like checkboxes after error appears
- **API** - Added `was cancelled` to determine whether request was cancelled by `beforeSend`
**Bugs**
**Fixes**
- **Build Tools** - Fixed issue with recursive merge for site themes in update scripts, [details here](https://github.com/Semantic-Org/Semantic-UI/pull/1845) Thanks @derekslife
- **Cards** - Fix `.ui.cards > .ui.card` margins to match `.ui.cards > .card` margins
- **Cards** - Fix consecutive card groups to preserve row flow (similar to consecutive grids)
@ -19,6 +22,9 @@
- **Grid** - Stackable grid now has horizontal padding by default on mobile unless nested inside a `ui grid` or `ui segment` (not vertical)
- **Menu** - Fixes pointing menu displaying under dropdown menu
-**Docs**
-**Transition** - `useFailSafe` was incorrectly shown as `false` by default
### Version 1.9.3 - February 20, 2015
**Bugs**

9
src/definitions/modules/transition.js

@ -181,7 +181,7 @@ $.fn.transition = function() {
;
},
complete: function () {
complete: function (event) {
module.verbose('CSS animation complete', settings.animation);
module.remove.animationEndCallback();
module.remove.failSafe();
@ -385,7 +385,9 @@ $.fn.transition = function() {
var
duration = module.get.duration()
;
module.timer = setTimeout(module.complete, duration + 100);
module.timer = setTimeout(function() {
$module.trigger(animationEnd);
}, duration + settings.failSafeDelay);
module.verbose('Adding fail safe timer', module.timer);
}
},
@ -899,6 +901,9 @@ $.fn.transition.settings = {
// whether timeout should be used to ensure callback fires in cases animationend does not
useFailSafe : true,
// delay in ms for fail safe
failSafeDelay: 100,
// whether EXACT animation can occur twice in a row
allowRepeats : false,

Loading…
Cancel
Save