diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 1bf322154..3d095fdb0 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -9,7 +9,6 @@ - **Label** - Added `basic` label variation, useful for item counts - **Button** - Added `labeled button` variation for display a count next to a button. - **Divider** - Vertical divider can now be used multiple times in a single column row (not just 50/50 split). #2808 -- **Icon** - Fixed typo in cube icon alias caused by bad grep #2765 **Additional Enhancements** - **Menu** - `text menu` now uses padding for hitboxes to make target area for links larger @@ -22,6 +21,9 @@ - **Modal** - Fix autofocus setting in modal not working due to improper selector #2737 - **Modal** - Increased `close` specificity, modal will now only close on `> .close` #2736 - **Accordion** - Added missing notation for accordion docs #2812 +- **Icon** - Fixed typo in cube icon alias caused by bad grep #2765 +- **Embed** - Remove accidental `console.log` statements in js #2760 +- **Transition** - Transition callbacks now all have the correct `this` set. #2758 **Additional Bugs** - **Build Tools** - Fixes issue on `win` platform where packaged theme would not correctly update when using watch due to regExp not matching windows path separators. diff --git a/src/definitions/modules/transition.js b/src/definitions/modules/transition.js index 8dba12751..882e79b6c 100644 --- a/src/definitions/modules/transition.js +++ b/src/definitions/modules/transition.js @@ -392,7 +392,7 @@ $.fn.transition = function() { module.add.failSafe(); } module.set.duration(settings.duration); - settings.onStart.call(this); + settings.onStart.call(element); } }, @@ -768,8 +768,8 @@ $.fn.transition = function() { module.remove.visible(); module.set.hidden(); module.force.hidden(); - settings.onHide.call(this); - settings.onComplete.call(this); + settings.onHide.call(element); + settings.onComplete.call(element); // module.repaint(); }, @@ -778,8 +778,8 @@ $.fn.transition = function() { module.remove.hidden(); module.set.visible(); module.force.visible(); - settings.onShow.call(this); - settings.onComplete.call(this); + settings.onShow.call(element); + settings.onComplete.call(element); // module.repaint(); },