From 089bf334009ff145f09bdf23e1584dba312f9938 Mon Sep 17 00:00:00 2001 From: jlukic Date: Thu, 26 Feb 2015 15:55:01 -0500 Subject: [PATCH] Slight modification to remove looping --- RELEASE-NOTES.md | 4 ++-- src/definitions/modules/transition.js | 17 ++++++++++------- src/themes/default/modules/transition.overrides | 2 +- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 8308623b6..d4af989e1 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -3,7 +3,6 @@ ### Version 1.11.0 - February xx, 2015 **New Components** - - **Visibiliity** - Attach callbacks to elements visibility conditions like `top visible` `bottom visible`, `passing`. Useful for things like: image lazy loading, infinite scroll content, and recording tracking metrics **Enhancements** @@ -13,9 +12,10 @@ - **Transition** - transition now has `stop`, `stop all`, and `clear queue` for removing transitions, (undocumented method `stop`, and `start` renamed to `enable` and `disable`) **Bugs** +- **Dropdown** - Fixes issue where dropdown would not open after restoring previus value on failed `search dropdown` search - **Transition** - Fixes `swing out` animations not working correctly - **Transition** - Fixed display state other than `block` not determined when using `show` and `hide` without an animation -- **Transition** - Fix bug in `remove looping` causing one additional animation +- **Transition** - Fix bug in `remove looping` causing next animation to use same duration - **Menu** - Fix vertical pointing menu, sub menu arrow color - **Item ** - `img` inside of `ui item content` now do not receive size formatting by default - **Form** - Added `input[type="search"]` styles to `ui form` diff --git a/src/definitions/modules/transition.js b/src/definitions/modules/transition.js index 254411409..ace7b0034 100644 --- a/src/definitions/modules/transition.js +++ b/src/definitions/modules/transition.js @@ -392,11 +392,13 @@ $.fn.transition = function() { $module.removeAttr('class'); } if(module.cache.style) { + console.log(module.cache.style); module.verbose('Restoring original style attribute', module.cache.style); $module.attr('style', module.cache.style); } - if(module.is.looping()) { - module.remove.looping(); + else { + module.verbose('Clearing style attribute'); + $module.removeAttr('style'); } module.verbose('Restoring original attributes', module.cache); } @@ -462,11 +464,12 @@ $.fn.transition = function() { }, looping: function() { module.debug('Transitions are no longer looping'); - $module - .removeClass(className.looping) - ; - module.reset(); - module.forceRepaint(); + if( module.is.looping() ) { + module.reset(); + $module + .removeClass(className.looping) + ; + } }, transition: function() { $module diff --git a/src/themes/default/modules/transition.overrides b/src/themes/default/modules/transition.overrides index a8b9d61af..c41566d31 100644 --- a/src/themes/default/modules/transition.overrides +++ b/src/themes/default/modules/transition.overrides @@ -269,7 +269,7 @@ .flip.transition.in, .flip.transition.out { - animation-duration: 750ms; + animation-duration: 600ms; perspective: 2000px; } .horizontal.flip.transition.in {