From 032871e045649d4dad88c543264ae5af2d4f7b9b Mon Sep 17 00:00:00 2001 From: jlukic Date: Sat, 19 Oct 2013 17:37:33 -0400 Subject: [PATCH] Renames invoked response to returnedValue for clarity, fixes issue when non string values are returned in array --- src/modules/accordion.js | 16 ++++++------- src/modules/behavior/api.js | 16 ++++++------- src/modules/behavior/form.js | 16 ++++++------- src/modules/behavior/state.js | 16 ++++++------- src/modules/chatroom.js | 4 ++-- src/modules/checkbox.js | 26 +++++++++++++-------- src/modules/dimmer.js | 16 ++++++------- src/modules/dropdown.js | 20 ++++++++-------- src/modules/modal.js | 16 ++++++------- src/modules/nag.js | 16 ++++++------- src/modules/popup.js | 44 +++++++++++++++++++++++------------ src/modules/rating.js | 16 ++++++------- src/modules/search.js | 16 ++++++------- src/modules/shape.js | 16 ++++++------- src/modules/sidebar.js | 16 ++++++------- src/modules/tab.js | 16 ++++++------- src/modules/transition.js | 16 ++++++------- src/modules/video.js | 16 ++++++------- 18 files changed, 169 insertions(+), 149 deletions(-) diff --git a/src/modules/accordion.js b/src/modules/accordion.js index ecbb4aa01..a9c91109f 100755 --- a/src/modules/accordion.js +++ b/src/modules/accordion.js @@ -21,7 +21,7 @@ $.fn.accordion = function(parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules .each(function() { @@ -348,14 +348,14 @@ $.fn.accordion = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -374,8 +374,8 @@ $.fn.accordion = function(parameters) { } }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/behavior/api.js b/src/modules/behavior/api.js index bfe7a138f..d2da587c6 100755 --- a/src/modules/behavior/api.js +++ b/src/modules/behavior/api.js @@ -47,7 +47,7 @@ queryArguments = [].slice.call(arguments, 1), module, - invokedResponse + returnedValue ; module = { @@ -494,14 +494,14 @@ else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -520,8 +520,8 @@ module.initialize(); } - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/behavior/form.js b/src/modules/behavior/form.js index 4b99faa7f..78253aa89 100755 --- a/src/modules/behavior/form.js +++ b/src/modules/behavior/form.js @@ -35,7 +35,7 @@ $.fn.form = function(fields, parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules .each(function() { @@ -532,14 +532,14 @@ $.fn.form = function(fields, parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -560,8 +560,8 @@ $.fn.form = function(fields, parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/behavior/state.js b/src/modules/behavior/state.js index 966d58849..5815a16cc 100755 --- a/src/modules/behavior/state.js +++ b/src/modules/behavior/state.js @@ -37,7 +37,7 @@ $.fn.state = function(parameters) { moduleNamespace = namespace + '-module', - invokedResponse + returnedValue ; $allModules .each(function() { @@ -582,14 +582,14 @@ $.fn.state = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -610,8 +610,8 @@ $.fn.state = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/chatroom.js b/src/modules/chatroom.js index e98b3f9ad..3821922c7 100755 --- a/src/modules/chatroom.js +++ b/src/modules/chatroom.js @@ -585,8 +585,8 @@ $.fn.chatroom = function(parameters) { }) ; - return (invokedResponse) - ? invokedResponse + return (returnedValue) + ? returnedValue : this ; }; diff --git a/src/modules/checkbox.js b/src/modules/checkbox.js index 0662ebc77..c0f6cf489 100755 --- a/src/modules/checkbox.js +++ b/src/modules/checkbox.js @@ -22,7 +22,7 @@ $.fn.checkbox = function(parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules @@ -90,6 +90,12 @@ $.fn.checkbox = function(parameters) { is: { radio: function() { return $module.hasClass(className.radio); + }, + enabled: function() { + return $input.prop('checked') !== undefined && $input.prop('checked'); + }, + disabled: function() { + return !module.is.enabled(); } }, @@ -122,10 +128,10 @@ $.fn.checkbox = function(parameters) { toggle: function(event) { module.verbose('Determining new checkbox state'); - if($input.prop('checked') === undefined || !$input.prop('checked')) { + if( module.is.disabled() ) { module.enable(); } - else if( module.can.disable() ) { + else if( module.is.enabled() && module.can.disable() ) { module.disable(); } }, @@ -274,14 +280,14 @@ $.fn.checkbox = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -302,8 +308,8 @@ $.fn.checkbox = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/dimmer.js b/src/modules/dimmer.js index 4fb3fffb5..7a9660f0c 100755 --- a/src/modules/dimmer.js +++ b/src/modules/dimmer.js @@ -22,7 +22,7 @@ $.fn.dimmer = function(parameters) { methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules @@ -479,14 +479,14 @@ $.fn.dimmer = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -509,8 +509,8 @@ $.fn.dimmer = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/dropdown.js b/src/modules/dropdown.js index e7c8132e3..81094c9ed 100755 --- a/src/modules/dropdown.js +++ b/src/modules/dropdown.js @@ -24,7 +24,7 @@ $.fn.dropdown = function(parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules @@ -240,7 +240,7 @@ $.fn.dropdown = function(parameters) { settings.action(text, value); } else { - module.error(error.action); + module.error(error.action, settings.action); } }, intent: function(event, callback) { @@ -457,7 +457,7 @@ $.fn.dropdown = function(parameters) { ; } else { - module.error(error.transition); + module.error(error.transition, settings.transition); } } }, @@ -718,14 +718,14 @@ $.fn.dropdown = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -746,8 +746,8 @@ $.fn.dropdown = function(parameters) { }) ; - return (invokedResponse) - ? invokedResponse + return (returnedValue) + ? returnedValue : this ; }; diff --git a/src/modules/modal.js b/src/modules/modal.js index 07380d22b..7131481ce 100755 --- a/src/modules/modal.js +++ b/src/modules/modal.js @@ -24,7 +24,7 @@ $.fn.modal = function(parameters) { methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; @@ -520,14 +520,14 @@ $.fn.modal = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -548,8 +548,8 @@ $.fn.modal = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/nag.js b/src/modules/nag.js index 25d520b49..0ef915083 100755 --- a/src/modules/nag.js +++ b/src/modules/nag.js @@ -22,7 +22,7 @@ $.fn.nag = function(parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $(this) .each(function() { @@ -448,14 +448,14 @@ $.fn.nag = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -475,8 +475,8 @@ $.fn.nag = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/popup.js b/src/modules/popup.js index 62e5daa77..69277e8cf 100755 --- a/src/modules/popup.js +++ b/src/modules/popup.js @@ -26,7 +26,7 @@ $.fn.popup = function(parameters) { methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules .each(function() { @@ -196,7 +196,8 @@ $.fn.popup = function(parameters) { } }, - show: function() { + show: function(callback) { + callback = callback || function(){}; module.debug('Showing pop-up', settings.transition); if( !module.exists() ) { module.create(); @@ -207,20 +208,27 @@ $.fn.popup = function(parameters) { ; if(settings.transition && $.fn.transition !== undefined) { $popup - .transition(settings.transition + ' in', settings.duration, module.bind.close) + .transition(settings.transition + ' in', settings.duration, function() { + module.bind.close(); + $.proxy(callback, element)(); + }) ; } else { $popup .stop() - .fadeIn(settings.duration, settings.easing, module.bind.close) + .fadeIn(settings.duration, settings.easing, function() { + module.bind.close(); + $.proxy(callback, element)(); + }) ; } $.proxy(settings.onShow, $popup)(); }, - hide: function() { + hide: function(callback) { + callback = callback || function(){}; $module .removeClass(className.visible) ; @@ -229,13 +237,19 @@ $.fn.popup = function(parameters) { module.debug('Hiding pop-up'); if(settings.transition && $.fn.transition !== undefined) { $popup - .transition(settings.transition + ' out', settings.duration, module.reset) + .transition(settings.transition + ' out', settings.duration, function() { + module.reset(); + callback(); + }) ; } else { $popup .stop() - .fadeOut(settings.duration, settings.easing, module.reset) + .fadeOut(settings.duration, settings.easing, function() { + module.reset(); + callback(); + }) ; } } @@ -668,7 +682,7 @@ $.fn.popup = function(parameters) { return false; } else { - module.error(error.method); + module.error(error.method, query); return false; } }); @@ -679,14 +693,14 @@ $.fn.popup = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -707,8 +721,8 @@ $.fn.popup = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/rating.js b/src/modules/rating.js index 4e649535d..a182b26a0 100755 --- a/src/modules/rating.js +++ b/src/modules/rating.js @@ -22,7 +22,7 @@ $.fn.rating = function(parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules .each(function() { @@ -339,14 +339,14 @@ $.fn.rating = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -366,8 +366,8 @@ $.fn.rating = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/search.js b/src/modules/search.js index b5e89730e..21c0d4214 100755 --- a/src/modules/search.js +++ b/src/modules/search.js @@ -22,7 +22,7 @@ $.fn.search = function(source, parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $(this) .each(function() { @@ -554,14 +554,14 @@ $.fn.search = function(source, parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -582,8 +582,8 @@ $.fn.search = function(source, parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/shape.js b/src/modules/shape.js index b7124ce7e..4051fe13e 100755 --- a/src/modules/shape.js +++ b/src/modules/shape.js @@ -21,7 +21,7 @@ $.fn.shape = function(parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules @@ -690,14 +690,14 @@ $.fn.shape = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -718,8 +718,8 @@ $.fn.shape = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/sidebar.js b/src/modules/sidebar.js index 6d35599c7..8bcd3ba5f 100755 --- a/src/modules/sidebar.js +++ b/src/modules/sidebar.js @@ -22,7 +22,7 @@ $.fn.sidebar = function(parameters) { query = arguments[0], methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules @@ -419,14 +419,14 @@ $.fn.sidebar = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -446,8 +446,8 @@ $.fn.sidebar = function(parameters) { }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/tab.js b/src/modules/tab.js index 8a1782ba5..4b0d9e74a 100755 --- a/src/modules/tab.js +++ b/src/modules/tab.js @@ -47,7 +47,7 @@ queryArguments = [].slice.call(arguments, 1), module, - invokedResponse + returnedValue ; module = { @@ -607,14 +607,14 @@ else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -633,8 +633,8 @@ module.initialize(); } - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; diff --git a/src/modules/transition.js b/src/modules/transition.js index d2529ec9a..aeee7158e 100755 --- a/src/modules/transition.js +++ b/src/modules/transition.js @@ -30,7 +30,7 @@ $.fn.transition = function() { || window.msRequestAnimationFrame || function(callback) { setTimeout(callback, 0); }, - invokedResponse + returnedValue ; $allModules .each(function() { @@ -582,14 +582,14 @@ $.fn.transition = function() { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found || false; } @@ -597,8 +597,8 @@ $.fn.transition = function() { module.initialize(); }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; }; diff --git a/src/modules/video.js b/src/modules/video.js index b0261033d..04d80ec75 100755 --- a/src/modules/video.js +++ b/src/modules/video.js @@ -24,7 +24,7 @@ $.fn.video = function(parameters) { methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - invokedResponse + returnedValue ; $allModules @@ -378,14 +378,14 @@ $.fn.video = function(parameters) { else if(found !== undefined) { response = found; } - if($.isArray(invokedResponse)) { - invokedResponse.push(response); + if($.isArray(returnedValue)) { + returnedValue.push(response); } - else if(typeof invokedResponse == 'string') { - invokedResponse = [invokedResponse, response]; + else if(returnedValue !== undefined) { + returnedValue = [returnedValue, response]; } else if(response !== undefined) { - invokedResponse = response; + returnedValue = response; } return found; } @@ -405,8 +405,8 @@ $.fn.video = function(parameters) { } }) ; - return (invokedResponse !== undefined) - ? invokedResponse + return (returnedValue !== undefined) + ? returnedValue : this ; };